Skip to content

chore: fix JavaScript lint errors (issue #12411)#12412

Open
narutamaaurum wants to merge 1 commit into
stdlib-js:developfrom
narutamaaurum:fix/lint-no-new-array
Open

chore: fix JavaScript lint errors (issue #12411)#12412
narutamaaurum wants to merge 1 commit into
stdlib-js:developfrom
narutamaaurum:fix/lint-no-new-array

Conversation

@narutamaaurum
Copy link
Copy Markdown

@narutamaaurum narutamaaurum commented Jun 1, 2026

Resolves #12411

Summary

Fixes 2 lint errors in lib/node_modules/@stdlib/stats/ztest2/examples/index.js by replacing new Array() constructor calls with array literals and .push(), as required by the stdlib/no-new-array lint rule.

Changes

  • Line 31: new Array(100)[] with .push() in loop

  • Line 36: new Array(80)[] with .push() in loop

  • Read, understood, and followed the contributing guidelines

Replace new Array() constructor with array literal and push
as required by stdlib/no-new-array lint rule.

Resolves stdlib-js#12411
@narutamaaurum narutamaaurum requested a review from a team June 1, 2026 01:19
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. labels Jun 1, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

2 participants